Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle subquery merging with references correctly #8658

Closed
wants to merge 1 commit into from

Conversation

systay
Copy link
Collaborator

@systay systay commented Aug 23, 2021

Description

Make sure to merge subqueries where either the inner or the outer are reference tables.

Related Issue(s)

Fixes #8638

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@frouioui
Copy link
Member

in TestSubqueryCanMerge, the testcases matrix should be:

	testcases := [engine.NumRouteOpcodes][engine.NumRouteOpcodes]bool{
		{true, false, false, false, false, false, false, true, false},
		{false, false, false, false, false, false, false, true, false},
		{false, false, false, false, false, false, false, true, false},
		{false, false, false, false, false, false, false, true, false},
		{false, false, false, false, false, false, false, true, false},
		{false, false, false, false, false, false, false, true, false},
		{false, false, false, false, false, false, true, true, false},
		{true, true, true, true, true, true, true, true, true},
		{false, false, false, false, false, false, false, true, false},
	}

@harshit-gangal
Copy link
Member

this needs to be fixed in all releases and main.

@systay systay closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants