Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtexplain examples #8652

Merged
merged 2 commits into from
Aug 20, 2021
Merged

vtexplain examples #8652

merged 2 commits into from
Aug 20, 2021

Conversation

hallaroo
Copy link
Member

Adding files to the local example folder for vitessio/website#803

@hallaroo hallaroo requested a review from deepthi August 20, 2021 17:33
@hallaroo
Add files via upload
14fa1aa 
Signed-off-by: hallaroo <[email protected]>
@hallaroo hallaroo force-pushed the hallaroo-patch-atomicity branch from 650b5de to 14fa1aa Compare August 20, 2021 19:01
deepthi
deepthi reviewed Aug 20, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be picky, but it will be better to put all these files in a separate directory called vtexplain.
Then you could remove the vtexplain_ prefix from the file names.
Otherwise it might be confusing for new users.

@deepthi deepthi changed the title Add files via upload vtexplain examples Aug 20, 2021
@hallaroo
moving files
c868fab 
Signed-off-by: hallaroo <[email protected]>
deepthi
deepthi approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for adding this.

@deepthi deepthi merged commit 6d6293c into main Aug 20, 2021
@deepthi deepthi deleted the hallaroo-patch-atomicity branch August 20, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hallaroo @deepthi @frouioui