servenv: add --onclose_timeout flag
#8651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new `--onclose_timeout` flag that adds a timeout for `onClose` hooks. It's very similar to the existing `--onterm_timeout` flag. This will be useful for services who use the `--lameduck-period` flag in conjuction with `onClose` hooks. In this scenario, a service doesn't have the ability to add timeouts to `onClose` hooks, hence it could lead a `onClose` hook to block the shutdown of a service. Signed-off-by: Fatih Arslan <[email protected]>
frouioui
added
Component: Cluster management
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--onclose_timeoutflag that adds a timeout foronClosehooks. It's very similar to the existing--onterm_timeoutflag.
The flag will be helpful for services that use the
--lameduck-periodflagin conjunction with
onClosehooks. In this scenario, a service can't addtimeouts to
onClosehooks; hence blocking the service shutdown.