srvtopo: allow unwatching from watch callbacks #8633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicent Marti <[email protected]>
harshit-gangal
requested review from
rafael,
shlomi-noach and
systay
as code owners
|
Recreated the PR from #8594 as that PR was created on a personal fork and there I do not have permission to push changes to trigger CI tests. |
harshit-gangal
added
Component: Cluster management
Type: Enhancement
3 tasks
harshit-gangal
requested review from
deepthi
and removed request for
rafael and
shlomi-noach
|
My comment is the same as before - we need an example of how to use the callback to unwatch. |
…l update to topo Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
deepthi
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From @vmg:
"Here's a feature I forgot to implement in my previous PR. We're gonna need to stop watching specific keyspaces once we detect their cluster event is finished."
cc @deepthi @harshit-gangal @rohit-nayak-ps
Related Issue(s)
#8462
Checklist
Deployment Notes