Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws-sdk-go to v1.34.2 #8632

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Bump aws-sdk-go to v1.34.2 #8632

merged 2 commits into from
Aug 16, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Aug 16, 2021

Description

go get -u github.com/aws/[email protected] && go mod tidy

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required N/A
  • Documentation was added or is not required N/A

Deployment Notes

guidoiaquinti
guidoiaquinti approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@guidoiaquinti guidoiaquinti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I’ve opened the issue to discuss with maintainer how we manage security issues in 3rd party dependencies. I’m asking because I wasn’t expecting to see this CVE still not fixed as of today. I also don’t see any issue opened by Dependabot regarding this

@ajm188 ajm188 merged commit 29c4dc0 into vitessio:main Aug 16, 2021
@ajm188 ajm188 deleted the am_bump_awssdk branch August 16, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidoiaquinti guidoiaquinti guidoiaquinti approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Build/CI Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade aws-sdk-go to >= v1.34.2
3 participants
@ajm188 @guidoiaquinti @frouioui