VStream API: Add flag to stop streaming on a reshard #8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
added
Component: VReplication
Type: Enhancement
…ournal event instead Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
force-pushed
the
rn-vstream-api-stop-on-reshard
branch
from
d8149d3 to
88ad81f
Compare
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
requested review from
deepthi and
sougou
and removed request for
systay
deepthi
reviewed
Aug 17, 2021
| @@ -56,6 +56,8 @@ var ( | |||
| "vreplication_cellalias", | |||
| "vstream_failover", | |||
| "vreplication_v2", | |||
| "vstream_stoponreshard_true", | |||
There was a problem hiding this comment.
Just for readability, you might consider adding more underscores.
There was a problem hiding this comment.
Will fix in my next PR, don't feel like babysitting CI for a couple of hours for this ...
sougou
approved these changes
Aug 17, 2021
DeathBorn
added a commit
to vinted/vitess
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Vilius Okockis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new flag StopOnReshard is added as an option that the VStream client can provide. Usually on a reshard of a shard that is participating in the stream, the VStream API sends all the events on the original shard and then automatically starts streaming from the new shard set. In this case the journal event is not sent on the stream.
This flag, if set, stops the stream after sending all the streams upto the reshard and includes the journal event pertaining to that reshard as the last event.
Signed-off-by: Rohit Nayak [email protected]
Related Issue(s)
#8595
Checklist
Deployment Notes