Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized CreateLookUpVindex to Include a Flag to Continue Vreplication After Backfill with an Owner Provided #8572

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

michaelhzh
Copy link

Description

This is PR for issue #8571 , which is to allow forces vreplication to continue after backfill with an owner being provided.

Related Issue(s)

#8571

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Aug 3, 2021
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps
Copy link
Contributor

Just noting doc snippet provided by @michaelhzh for the -continue_after_copy_with_owner flag. To be added to vitess.io:

By default, when an owner is provided, the VReplication streams will stop after the Vindex backfill completes. Set this flag if you don’t want this to happen.

Uses

  • When used in table migration from unsharded to sharded, it can override the default behavior of the workflow and continue the Vreplication Stream after Vindex backfill is completed. This allows Vindex to be kept up to date when the read and write still points to the original table at the unsharded keyspace, avoiding another backfill before SwitchWrites and any inconsistencies in Vindex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants