Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customized CreateLookUpVindex to be Compatible with non-consistent Lookup Vindex #8570

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Customized CreateLookUpVindex to be Compatible with non-consistent Lookup Vindex #8570

merged 1 commit into from
Aug 26, 2021

Conversation

michaelhzh
Copy link

Description

I previously made some mistake with PR #8539 and therefore is starting a new PR to replace it. The content is the same. This is PR for #8523 , which is to allow CreateLookupVindex to be compatible with a wider variety of Lookup Vindex.

Related Issue(s)

#8523

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@michaelhzh michaelhzh mentioned this pull request Jul 30, 2021
Closed
2 tasks
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Aug 4, 2021
@rohit-nayak-ps
Copy link
Contributor

Documentation snippet provided by @michaelhzh, which I will add soon in a vitess.io website PR:

Data_Type is an optional parameter that has a default value of varbinary(128) used to store hashed value. However, sometimes you might want to Vindex to store unhashed value that has a different data type from varbinary(128) . In those cases, you would put the corresponding data type of the column you want to build Vindex for. An example of such data type would be bigint(20)

rohit-nayak-ps
rohit-nayak-ps approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit bd91b42 into vitessio:main Aug 26, 2021
@frouioui frouioui mentioned this pull request Aug 26, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelhzh @rohit-nayak-ps @frouioui @zhePin