Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Chorlton [email protected]
Description
Just registers the grpc server in
servenv
as part of the reflection API. This should allow us to rungrpcurl ... list
.It's just a nice-to-have convenience thing. It's more useful as vitess combines servers into a single entrypoint with servers activated by flag, so we can trivially tell what RPCs are available without digging through source.
Related Issue(s)
N/A
Checklist
Deployment Notes
I'd appreciate some help testing this. I tried to get a quick vitess server up and running just to make sure it didn't crash on boot. I couldn't find instructions, and couldn't find a grpc server that was trivial to start without e.g. a valid topo-srv running. Is there a good way to test this without hacking about in docker compose or other and getting the whole stack running?