Clear only the current shard's schemacopy rows during schema reload #8519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing reload Signed-off-by: Florent Poinsard <[email protected]>
frouioui
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
systay
reviewed
Jul 23, 2021
|
|
||
| exec(t, conn, "drop table test_table") | ||
|
|
||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
Schema tracking needs enough time to propagate the schema changes implied by DROP TABLE
There was a problem hiding this comment.
Reload interval is set to 0.1 second, 2 seconds is plenty and should not flake the test
There was a problem hiding this comment.
we have assertmatcheswithtimeout for that.
There was a problem hiding this comment.
The function assertMatchesWithTimeout delays the call to exec while making sure the call does not exceed a certain timeout, the goal of the time.Sleep here is a little different as I am trying to wait after the completion of the exec
harshit-gangal
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes VTTablet clear only the rows that match the current database name and the updated tables in
schemacopy; instead of clearing all the rows that match the updated tables. This will be useful for @GuptaManan100 when testing the Rails guide against a sharded cluster.VTTestServer uses a single MySQL instance where the different shards are suffixed in the
table_schemacolumn by their name (-80,80-, etc). Removing all the rows from theschemacopytables was making the shards not agreeing and made them repetitively send schema updates to VTGate.After testing VTTestServer with schema tracking enabled: it is preferable to lower the schema update interval in the VTTablets or add multiple timeouts in the Rails test suite.
Related Issue(s)
Resolves #8510
Checklist