Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boolean values should not be parenthesised in default clause #8502

Merged
merged 1 commit into from
Jul 20, 2021
Merged

boolean values should not be parenthesised in default clause #8502

merged 1 commit into from
Jul 20, 2021

Conversation

GuptaManan100
Copy link
Member

Description

Currently parsing the following query

create table function_default (x bool DEFAULT true)

gives the output

create table function_default (x bool DEFAULT (true))

but this is incorrect and will not work against MySQL5.7. This PR fixes it.

Related Issues

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@systay systay merged commit ede1c3b into vitessio:main Jul 20, 2021
@systay systay deleted the default-bool branch July 20, 2021 11:25
@GuptaManan100 GuptaManan100 mentioned this pull request Jul 26, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boolean values in default clause
3 participants
@GuptaManan100 @systay @frouioui