Remove lingering mysqld sock files on vttestserver container startup

[ilikeorangutans]

Description

When restarting vttestserver after an ungraceful shutdown mysql doesn't start up due to the lingering sock files. Took the snippet from vitess/examples/compose/vttablet-up.sh and added it to vttestserver's run.sh:

vitess/examples/compose/vttablet-up.sh

Lines 90 to 94 in 345d30a

	# Delete socket files before running mysqlctld if exists.
	# This is the primary reason for unhealthy state on restart.
	# https://github.com/vitessio/vitess/pull/5115/files
	echo "Removing $VTDATAROOT/$tablet_dir/{mysql.sock,mysql.sock.lock}..."
	rm -rf $VTDATAROOT/$tablet_dir/{mysql.sock,mysql.sock.lock}

Related Issue(s)

• helm: delete mysql.sock.lock in init container #5115

Checklist

• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[dkhenry]

LGTM

[mcronce]

I think this looks good, the only thing I'd change would be to not rm with -r, since the things we expect to delete aren't directories

[ilikeorangutans]

I think this looks good, the only thing I'd change would be to not rm with -r, since the things we expect to delete aren't directories

Good call. I'll update.

I'm surprised by all the failing tests. Could there be tests that rely on the sock file to remain?

[GuptaManan100]

LGTM