[vtadmin] Add Options struct to wrap grpc/http options #8461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some other branches, the API is going to need more options that don't fit neatly into either the grpcserver.Options or http.Options structs, so this will give us a more general scope to put them in. Signed-off-by: Andrew Mason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some other branches, the API is going to need more options that
don't fit neatly into either the grpcserver.Options or http.Options
structs, so this will give us a more general scope to put them in.
I'm getting this refactor in now because the diff is noisy, and I don't
want it in the way of those other changes.
Signed-off-by: Andrew Mason [email protected]
Description
Related Issue(s)
Checklist
Deployment Notes