Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] Add a vtctld Dialer unit test #8455

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Jul 12, 2021

Signed-off-by: Sara Bee [email protected]

Description

This PR adds a test case for VTAdmin's existing vtctld Dial function.

Figured I'd peel off this one lil test case from the larger reconnect branch I'm working on, since it simply tests our current behaviour.

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

@doeg doeg requested a review from ajm188 July 12, 2021 18:41
@doeg doeg requested a review from rohit-nayak-ps as a code owner July 12, 2021 18:41
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ajm188 ajm188 merged commit 4ecb8c7 into vitessio:main Jul 12, 2021
@ajm188 ajm188 deleted the sarabee-a-vtadmin-vtctld-dial-test-for-ants branch July 12, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants