Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "no-scatter" flag to prohibit the use of scatter queries #8439

Merged
merged 7 commits into from
Jul 13, 2021
Merged

Add "no-scatter" flag to prohibit the use of scatter queries #8439

merged 7 commits into from
Jul 13, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 8, 2021 •
edited
Loading

Description

Adds a flag, no-scatter that makes the planner fail if scatter queries are produced by the planner.

TODO

  • Add query hint that allows the use of scatter queries even when the no-scatter flag is on.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

systay added 2 commits July 8, 2021 16:43
@systay
add flag
0737800 
Signed-off-by: Andres Taylor <[email protected]>
@systay
fail executor if the no_scatter flag is enabled and the plan contains…
4b7274f 
… a scatter

Signed-off-by: Andres Taylor <[email protected]>
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Jul 8, 2021
@systay systay requested a review from harshit-gangal as a code owner July 8, 2021 16:15
@systay systay marked this pull request as draft July 8, 2021 16:15
@systay systay marked this pull request as ready for review July 13, 2021 11:13
@systay systay requested a review from GuptaManan100 as a code owner July 13, 2021 11:13
GuptaManan100
GuptaManan100 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏎️

frouioui
frouioui approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me!

@harshit-gangal harshit-gangal merged commit 0ecc59e into vitessio:main Jul 13, 2021
@harshit-gangal harshit-gangal deleted the no-scatter branch July 13, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@systay @mattlord @harshit-gangal @frouioui @GuptaManan100