Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin] cluster debug pages #8427

Merged
merged 7 commits into from
Jul 13, 2021
Merged

[vtadmin] cluster debug pages #8427

merged 7 commits into from
Jul 13, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jul 7, 2021

Description

What it says. Some notable callouts:

  • clusters, vtctld proxies, and vtgate proxies now take the config they were created from, so they can show this in the debug.
  • vtctld and vtgate proxies now track the time their connection was established, as well as the last time that connection was pinged (this is kind of a lie for vtctlds, but that is being fixed separately)
  • for credentials, we will never show passwords, only an indication of whether there's a password being used (eight asterisks) or not (empty string).

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@ajm188 ajm188 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface Component: Observability Pull requests that touch tracing/metrics/monitoring labels Jul 7, 2021
@ajm188 ajm188 requested a review from doeg July 7, 2021 17:27
@ajm188 ajm188 requested a review from rohit-nayak-ps as a code owner July 7, 2021 17:27
@ajm188 ajm188 force-pushed the am_vtadmin_clusterdebug branch from 8617479 to b0b9441 Compare July 12, 2021 22:55
doeg
doeg approved these changes Jul 12, 2021
View reviewed changes
go/vt/vtadmin/debug/debug.go

// TimeToString returns a time in RFC3339-formatted string, so all debug-related
// times are in the same format.
func TimeToString(t time.Time) string { return t.Format(time.RFC3339) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big thank for this

go/vt/vtadmin/debug/debug_test.go
func TestSanitizeString(t *testing.T) {
t.Parallel()

t.Run("empty string", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, TIL this t.Parallel construction. Very useful!

@ajm188
Guard against races
96ebfc2 
Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 merged commit 66513c9 into vitessio:main Jul 13, 2021
@ajm188 ajm188 deleted the am_vtadmin_clusterdebug branch July 13, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doeg doeg doeg approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajm188 @doeg @frouioui