-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Add ability to tag workflows #8388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking good to me! a comment about cli, and then also about keeping the new apis in sync (which, yes, we should unify soon, but for now)
b4c758a
to
30454e1
Compare
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
… the CI logs Speed up the teardown process, which was occassionally taking too long and causing tests to timeout Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
434c8a3
to
f4e7a7e
Compare
Signed-off-by: Rohit Nayak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing about the protobuf type change and then this lgtm whenever you want to move out of draft
Signed-off-by: Rohit Nayak <[email protected]>
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Users have requested the ability to group workflows. Some use cases:
This PR adds the ability to tag workflows in a simple and extensible way. It adds a
tags
column to the_vt.vreplication
table. Adding multiple tags is left as an implementation detail: the most obvious way would be to use a list of comma-separated tags in that column.This implementation also allows users to tag each stream in a workflow separately by specifying separate list of tags for each stream in the workflow on each target.
To add tags at the workflow level use the
Workflow
command thus:vtctlclient Workflow customer.cust2cust tags 'a,b'
to set the tags. Specify an empty string to reset the tags.To set tags at the stream level use
VReplicationExec
thus:vtctlclient VReplicationExec zone1-100 "update _vt.vreplication set tags = 'a,b' where workflow = 'cust2cust' and keyspace = 'customer'"
The wrangler function
wr.WorkflowTagAction(ctx, keyspace, workflow, tags)
can be used for programmatically setting it in, say,vtadmin
.Note that tags do not affect the core functionality of vreplication workflows.
Signed-off-by: Rohit Nayak [email protected]
Checklist