Resolve go.mod issue with direct dependency on planetscale/tengo

[shlomi-noach]

https://github.com/planetscale/tengo is a fork of https://github.com/skeema/tengo, where we add Vitess-specific code that is not likely to fit skeema/tengo.

Until today, we did a replace github.com/skeema/tengo => github.com/planetscale/tengo v0.9.6-ps.v3 in go.mod. This worked well for complete Vitess builds (make build etc).

However, we found out that in partial builds, such as in go get vitess.io/vitess/go/cmd/vtctlclient, go does not resolve the redirect correctly.

With this PR, we directly import planetscale/skeema. We also renamed planetscale/tengo's module name itself in planetscale/tengo#8 and tagged that as v0.9.6-ps.v4.

Related Issue(s)

Issue by community in slack.

Checklist

• Tests were added or are not required
• Documentation was added or is not required

[vmg]

This is indeed what I had in mind. Have you verified that this fixes the issue when go getting the subpackage?

[shlomi-noach]

Have you verified that this fixes the issue when go getting the subpackage?

Not sure how to do that while the PR is unmerged? Tried:

$ go get vitess.io/vitess/go/cmd/vtctlclient@c2cfb0ebfd424a308c0445b097c9d24bdfa20ab4
go get: vitess.io/vitess/go/cmd/vtctlclient@c2cfb0ebfd424a308c0445b097c9d24bdfa20ab4: invalid version: unknown revision c2cfb0ebfd424a308c0445b097c9d24bdfa20ab4

[shlomi-noach]

hmmm the reason this won't work is that the PR comes from planetscale/vitess

[shlomi-noach]

You know something, I don't even know what vitess.io resolves to in go get vitess.io/vitess/go/cmd/vtctlclient. How does this module get synced with GitHub?

[vmg]

@shlomi-noach: it's a n HTML <meta> trick on the vitess.io domain, and yes, I'm afraid that we'll need to merge this PR to test this live.

Here are the full docs FWIW: https://golang.org/cmd/go/#hdr-Remote_import_paths

[vmg]

This actually worked 🎉