Online DDL/VReplication test suite: support ENUM as part of PRIMARY KEY #8345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's valid to have an
enum
as part of aPRIMARY KEY
. In such scenario, we must treat theenum
as text and not as integer, to handle a scenario where a query may actually update the enum value (bad practice to update aPRIMARY KEY
value, but yet valid).Added tests:
enum-pk
- tests that enum PK works, that updates to enum (as part of PK) values workupdate-pk
- tests that varchar PK works, that updates to varchar (as part of PK) values workRelated Issue(s)
Checklist