Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL/VReplication test suite: support ENUM as part of PRIMARY KEY #8345

Merged

Conversation

shlomi-noach
Copy link
Contributor

Description

It's valid to have an enum as part of a PRIMARY KEY. In such scenario, we must treat the enum as text and not as integer, to handle a scenario where a query may actually update the enum value (bad practice to update a PRIMARY KEY value, but yet valid).

Added tests:

  • enum-pk - tests that enum PK works, that updates to enum (as part of PK) values work
  • update-pk - tests that varchar PK works, that updates to varchar (as part of PK) values work

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants