Heuristic fix for a flaky test: allow for some noise to pass through #8339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
|
2 successive successful completions for |
|
OK this continuously/consistently passes. |
rohit-nayak-ps
deleted the
flaky-test-expect-queries-allow-skippable-once
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt at fixing #8323
What happens in #8323 is that a
update _vt.vreplication set pos=query is encountered unexpectedly. This query can appear due to heartbeat leftovers from a previous test or from a heartbeat race condition.This PR allows for just a little bit of noise to pass through:
expectDBClientQueriessupportsskippableOnceoptional list of queries. It's OK to hit at most one of given skippable queries, once, while iterating expected queries.Related Issue(s)
Checklist