-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workaround xtrabackup error with old_alter_table #8317
Conversation
700a7a6
to
a2de4f7
Compare
Signed-off-by: deepthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to put a note somewhere in https://vitess.io/docs/user-guides/operating-vitess/backup-and-restore/creating-a-backup/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make sure this should not go into an earlier branch first
Noting that enabling |
@shlomi-noach afaict this change of behavior is only on the end-to-end tests and doesn't apply to normal production usage. |
Ah, then please just ignore me. |
Gonna resubmit these changes into |
Resubmitted against |
Closing so we don't accidentally hit that big green button |
Description
Some of the xtrabackup tests have been flaky for a while. Today @vmg was able to extract the actual error from a failing test.
This seems to be a known issue with a documented workaround. Implementing the workaround.
https://www.percona.com/blog/2017/08/08/avoiding-the-an-optimized-without-redo-logging-ddloperation-has-been-performed-error-with-percona-xtrabackup/
The blog post has 3 suggestions:
--lock-ddl
: only works with Percona MySQL server, we are running community MySQL server in CI--lock-ddl-per-table
: did not fix the problemold_alter_table
: 🤞Related Issue(s)
Fixes #8315
Checklist
Deployment Notes