Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Tracking Flaky Test: Ignore unrelated gtid progress events #8283

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Schema Tracking Flaky Test: Ignore unrelated gtid progress events #8283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions go/vt/vttablet/endtoend/vstreamer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,13 @@ func expectLogs(ctx context.Context, t *testing.T, query string, eventCh chan []
if !ok {
t.Fatal("expectLogs: not ok, stream ended early")
}
// Ignore unrelated gtid progress events that can race with the events that the test expects
if len(allevs) == 3 &&
allevs[0].Type == binlogdatapb.VEventType_BEGIN &&
allevs[1].Type == binlogdatapb.VEventType_GTID &&
allevs[2].Type == binlogdatapb.VEventType_COMMIT {
continue
}
for _, ev := range allevs {
// Ignore spurious heartbeats that can happen on slow machines.
if ev.Type == binlogdatapb.VEventType_HEARTBEAT {
Expand Down