Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter tests to reuse cluster components #8276

Merged
merged 29 commits into from
Jul 8, 2021
Merged

Alter tests to reuse cluster components #8276

merged 29 commits into from
Jul 8, 2021

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jun 7, 2021 •
edited
Loading

Description

This PR alters the vtorc tests to reuse the cluster components to speed them up. It also adds an additional test that checks for the failure case of circular replication. i.e. Primary and replica are replicating from each other.

Before the PR
BeforeChange

After the changes
AfterChange

The test time goes from almost 7 minutes to almost 4 minutes which is a 42.8% decrease in runtime.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@GuptaManan100
reuse vttablets too in the tests
8133c1f 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
added wait for tablet type in test setup
3332b49 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
pass mysql-hostname too for orchestrator to discover the tablet
52b7d02 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
change tablet type from master before deleting it
84fe9c1 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
allow force update of tablets
1f73243 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into vtorc-test-rewrite
07fbc29 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
delete the tablet for whom mysqlctl process is stopped
09492de 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
Revert "allow force update of tablets"
68c9436 
This reverts commit 1f73243.

Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
added additional command to demote master tablet to circumvent the si…
265019a 
…de effect of DeleteTablet shutting down the master tablet

Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review June 17, 2021 17:27
@GuptaManan100 GuptaManan100 marked this pull request as draft June 21, 2021 15:23
shlomi-noach
shlomi-noach reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Some nits inside

go/test/endtoend/cluster/vtorc_process.go Outdated Show resolved Hide resolved
go/test/endtoend/cluster/vttablet_process.go Outdated Show resolved Hide resolved
go/vt/vtctl/vtctl.go Outdated Show resolved Hide resolved
@GuptaManan100
cleanly shutdown all the mysql instances
368ce04 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
rename error file and a variable
b720b4a 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
shutdown and restart vttablets instead of removing them from topology
0fd39ae 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
move demoting replica tablet to a test only use function
dd2c841 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into vtorc-test-rewrite
5f8cc63 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
wait for the tablets to come up properly when restarted
253e473 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
bug fix
1191dfb 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
also delete tablet record after testdownmaster
fb5728a 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
Merge remote-tracking branch 'upstream/main' into vtorc-test-rewrite
22ab494 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100
drop _vt database too
18f01b1 
Signed-off-by: GuptaManan100 <[email protected]>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review July 7, 2021 11:43
shlomi-noach
shlomi-noach approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

deepthi
deepthi approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the reduction in test run time :)

go/vt/wrangler/tablet.go Outdated Show resolved Hide resolved
@GuptaManan100
revert unnecessary change
382d13f 
Signed-off-by: GuptaManan100 <[email protected]>
@harshit-gangal harshit-gangal merged commit ce04df8 into vitessio:main Jul 8, 2021
@harshit-gangal harshit-gangal deleted the vtorc-test-rewrite branch July 8, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi deepthi approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188

@doeg doeg Awaiting requested review from doeg

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees
No one assigned
Labels
Component: Cluster management Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuptaManan100 @deepthi @shlomi-noach @harshit-gangal @frouioui