Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vttestserver docker test #8253

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Vttestserver docker test #8253

merged 7 commits into from
Jun 10, 2021

Conversation

GuptaManan100
Copy link
Member

Description

This PR adds the tests for the docker image vttestserver. The tests are not run in CI but can be run by hand manually.

Related Issue(s)

Adds tests for #8210

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@GuptaManan100 GuptaManan100 mentioned this pull request Jun 3, 2021
Merged
2 tasks
@GuptaManan100 GuptaManan100 requested a review from frouioui June 3, 2021 09:14
@deepthi deepthi requested a review from mcronce June 3, 2021 20:14
mcronce
mcronce approved these changes Jun 7, 2021
View reviewed changes
Copy link

@mcronce mcronce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks real good to me

go/test/endtoend/docker/vttestserver_test.go Outdated Show resolved Hide resolved
@GuptaManan100 GuptaManan100 requested a review from mcronce June 9, 2021 07:55
mcronce
mcronce approved these changes Jun 9, 2021
View reviewed changes
Copy link

@mcronce mcronce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better ;)

@GuptaManan100
logged error in teardown
15fd287 
Signed-off-by: GuptaManan100 <[email protected]>
@harshit-gangal harshit-gangal merged commit 791df79 into vitessio:main Jun 10, 2021
@harshit-gangal harshit-gangal deleted the vttestserver-docker-test branch June 10, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcronce mcronce mcronce approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@frouioui frouioui Awaiting requested review from frouioui

Assignees
No one assigned
Labels
Component: vttestserver Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuptaManan100 @systay @mcronce @harshit-gangal