-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctldserver] Migrate remaining ServingGraph rpcs to VtctldServer #8249
[vtctldserver] Migrate remaining ServingGraph rpcs to VtctldServer #8249
Conversation
@@ -647,6 +663,41 @@ func (s *VtctldServer) GetShard(ctx context.Context, req *vtctldatapb.GetShardRe | |||
}, nil | |||
} | |||
|
|||
// GetSrvKeyspaceNames is part of the vtctlservicepb.VtctldServer interface. | |||
func (s *VtctldServer) GetSrvKeyspaceNames(ctx context.Context, req *vtctldatapb.GetSrvKeyspaceNamesRequest) (*vtctldatapb.GetSrvKeyspaceNamesResponse, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation seems to diverge from the existent one in vtctl: https://github.com/tinyspeck/vitess/blob/22bdd8a9304ec2499414a2526ea644a2925259d5/go/vt/vtctl/vtctl.go#L3240
Curious of the rationale for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In VTAdmin we've been finding that we almost always want to get "all of the things" for a given resource, so this let's us make one call to a vtctld rather than one call to get all the cells and then one call per cell.
Which reminds me ... I meant to update the old implementation to call this one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to demonstrate the old commands still work after my latest commit:
❯ vtctlclient -server "localhost:15999" GetSrvKeyspaceNames zone1
commerce
9f81489
to
4474886
Compare
rebased and regenerated protos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
4474886
to
6548ad5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR migrates the following RPCs to the VtctldServer:
DeleteSrvVSchema
GetSrvKeyspaceNames
Usage
Everything on the local example.
After running through the 2xx examples:
Related Issue(s)
Checklist
Deployment Notes