Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add Tab components #8119

Merged
merged 1 commit into from
May 14, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 13, 2021

Signed-off-by: Sara Bee [email protected]

Description

Tabs! Looks like this:

Screen Shot 2021-05-13 at 3 15 47 PM

Screen Shot 2021-05-13 at 3 15 50 PM

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

@doeg doeg requested review from rafael, ajm188 and rohit-nayak-ps May 13, 2021 18:31
@doeg
Copy link
Contributor Author

doeg commented May 13, 2021

Ugh one sec, I noticed an alignment issue. 😑 Ok, fixed!

@doeg doeg force-pushed the sarabee-vtadmin-tabs branch from cfb8cd6 to fbbce2e Compare May 13, 2021 19:15
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chef-kiss:

@ajm188 ajm188 merged commit 9efb2ce into vitessio:master May 14, 2021
@ajm188 ajm188 deleted the sarabee-vtadmin-tabs branch May 14, 2021 15:53
@ajm188 ajm188 added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants