Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Add DataFilter + Workspace layout components #8032

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 4, 2021

Description

Several tedious-but-satisfying layout changes to (a) streamline shared components, (b) bring them closer to parity with our Figma layouts, and (c) add scaffolding for the new split workspace layout, which is next up. 🎉

The diff is pretty mangled, but hiding whitespace changes helps a lot!

Here's what it looks like:

Before After
List schema-list-before schema-list-after2
Detail schema-detail-before2 schema-detail-after3

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

@doeg doeg requested review from rafael, ajm188 and rohit-nayak-ps May 4, 2021 16:18
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice!

@ajm188 ajm188 merged commit 21dae69 into vitessio:master May 5, 2021
@ajm188 ajm188 deleted the sarabee-vtadmin-web-content-bounds branch May 5, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants