Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wrangler|workflow] Extract workflowState and workflowType out to package workflow #7967

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[wrangler|workflow] Extract workflowState and workflowType out to package workflow #7967

merged 1 commit into from
Apr 30, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Apr 27, 2021 •
edited
Loading

Signed-off-by: Andrew Mason [email protected]

Description

Even moar refactors! This is the last one before the Big One to move traffic switcher out (I lied, there's one more after this :lolsob:). This one moves out wrangler.workflowState to workflow.State.

Related Issue(s)

Checklist

  • Tests were added or are not required n/a
  • Documentation was added or is not required

Deployment Notes

@ajm188 ajm188 requested a review from deepthi as a code owner April 27, 2021 14:14
rafael
rafael approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rohit-nayak-ps
rohit-nayak-ps approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajm188 ajm188 merged commit 025b4e2 into vitessio:master Apr 30, 2021
@ajm188 ajm188 deleted the am_extract_workflow_state branch April 30, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@rafael rafael rafael approved these changes

@doeg doeg Awaiting requested review from doeg

@makinje16 makinje16 Awaiting requested review from makinje16

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: VReplication Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajm188 @rafael @rohit-nayak-ps @askdba