Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] Display vindex data on Schema view #7917

Merged

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Apr 21, 2021

Signed-off-by: Sara Bee [email protected]

Description

As the title says, this PR introduces vindexes (when defined) to the Schema view.

Same general caveat that this is just a first pass -- indeed, I just copied this from our internal prototype. 😊 I think there's more we can do here, like link to other tables, add lil tooltips, etc. I'm certainly interested in ideas here, now or whenever.

Here's what it looks like with local Vitess, for a table with vindexes and for one without:
Screen Shot 2021-04-21 at 4 22 25 PM

Screen Shot 2021-04-21 at 4 22 33 PM

And here's a slightly more complicated example from the unit tests 🐕

Screen Shot 2021-04-21 at 4 46 28 PM

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@doeg doeg force-pushed the sarabee-vtadmin-web-schema-vindexes branch from 2426257 to 58ed5c4 Compare April 21, 2021 20:44
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@ajm188 ajm188 merged commit 5a03c07 into vitessio:master Apr 22, 2021
@systay systay added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Apr 28, 2021
@doeg doeg deleted the sarabee-vtadmin-web-schema-vindexes branch November 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants