Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups around errors on the vtgate #7864

Merged
merged 10 commits into from
Apr 21, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 14, 2021

Description

Removes redundant code and updates some error messages.

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving

@systay systay changed the title Remove redundant Minor cleanups around errors on the vtgate Apr 14, 2021
@systay systay force-pushed the remove-redundant branch from fc4b43e to 63b073e Compare April 15, 2021 13:49
@harshit-gangal
Copy link
Member

as the error message is changed, there are tests that needs to be fixed.

@systay systay requested a review from shlomi-noach as a code owner April 21, 2021 08:52
@harshit-gangal harshit-gangal removed the request for review from shlomi-noach April 21, 2021 10:57
GuptaManan100 and others added 8 commits April 21, 2021 13:25
Signed-off-by: GuptaManan100 <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
@systay systay force-pushed the remove-redundant branch from 8f27902 to 35b598a Compare April 21, 2021 11:25
@systay systay merged commit ff6b659 into vitessio:master Apr 21, 2021
@systay systay deleted the remove-redundant branch April 21, 2021 14:26
@systay systay added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants