Wrangler tests: Return a fake tablet in the wrangler test dialer to avoid tablet picker errors spamming the test logs

go/vt/wrangler/wrangler_env_test.go

@@ -63,12 +63,12 @@ func init() {
 	tabletconn.RegisterDialer("WranglerTest", func(tablet *topodatapb.Tablet, failFast grpcclient.FailFast) (queryservice.QueryService, error) {
 		wranglerEnv.mu.Lock()
 		defer wranglerEnv.mu.Unlock()
-		fmt.Println("In WranglerTest dialer")
 		if qs, ok := wranglerEnv.tablets[int(tablet.Alias.Uid)]; ok {
-			fmt.Printf("query service is %v", qs)
 			return qs, nil
 		}
-		return nil, fmt.Errorf("tablet %d not found", tablet.Alias.Uid)
+		// some tests don't require the query service. Earlier we were returning an error for such cases but the tablet picker
+		// now logs a warning and spams the logs. Hence we return a fake service instead
+		return newFakeTestWranglerTablet(), nil
 	})
 }
 
@@ -211,6 +211,24 @@ func (env *testWranglerEnv) close() {
 	env.tablets = nil
 }
 
+func newFakeTestWranglerTablet() *testWranglerTablet {
+	id := 999
+	tablet := &topodatapb.Tablet{
+		Alias: &topodatapb.TabletAlias{
+			Cell: "fake",
+			Uid:  uint32(id),
+		},
+		Keyspace: "fake",
+		Shard:    "fake",
+		KeyRange: &topodatapb.KeyRange{},
+		Type:     topodatapb.TabletType_MASTER,
+		PortMap: map[string]int32{
+			"test": int32(id),
+		},
+	}
+	return newTestWranglerTablet(tablet)
+}
+
 func (env *testWranglerEnv) addTablet(id int, keyspace, shard string, tabletType topodatapb.TabletType) *testWranglerTablet {
 	env.mu.Lock()
 	defer env.mu.Unlock()
@@ -316,13 +334,12 @@ func (tmc *testWranglerTMClient) VReplicationExec(ctx context.Context, tablet *t
 }
 
 func (tmc *testWranglerTMClient) ExecuteFetchAsApp(ctx context.Context, tablet *topodatapb.Tablet, usePool bool, query []byte, maxRows int) (*querypb.QueryResult, error) {
-	// fmt.Printf("tablet: %d query: %s\n", tablet.Alias.Uid, string(query))
 	t := wranglerEnv.tablets[int(tablet.Alias.Uid)]
 	t.gotQueries = append(t.gotQueries, string(query))
 	result, ok := t.queryResults[string(query)]
 	if !ok {
 		result = &querypb.QueryResult{}
-		log.Errorf("QUery: %s, Result :%v\n", query, result)
+		log.Errorf("Query: %s, Result :%v\n", query, result)
 	}
 	return result, nil
 }