Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to not log sensitive information #7774

Merged
merged 2 commits into from
Apr 1, 2021
Merged

make sure to not log sensitive information #7774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
016901d
make sure to not log sensitive information
systay Apr 1, 2021
4fd3140
addressed review comments
harshit-gangal Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion go/vt/vtgate/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ func (e *Executor) Execute(ctx context.Context, method string, safeSession *Safe
saveSessionStats(safeSession, stmtType, result, err)
if result != nil && len(result.Rows) > *warnMemoryRows {
warnings.Add("ResultsExceeded", 1)
log.Warningf("%q exceeds warning threshold of max memory rows: %v", sql, *warnMemoryRows)
piiSafeSQL, err := sqlparser.RedactSQLQuery(sql)
if err != nil {
piiSafeSQL = logStats.StmtType
}
log.Warningf("%q exceeds warning threshold of max memory rows: %v", piiSafeSQL, *warnMemoryRows)
}

logStats.Send()
Expand Down