Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug that prevents creation of logs directory #7761

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

GuptaManan100
Copy link
Member

Description

#7718 created a regression wherein the logs directory was not created if its parent directory already existed. The problematic line is at https://github.com/vitessio/vitess/pull/7718/files#diff-7be49867c740adb69b3abbb3d0bbbe92e1d34fcb944d2c5a3efa99f6a1439006R245. This PR fixes that issue.

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Copy link
Member

@hkdsun hkdsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that! 👍

@deepthi deepthi merged commit 586887c into vitessio:master Mar 30, 2021
@deepthi deepthi deleted the log-creation branch March 30, 2021 15:19
@askdba askdba added this to the v10.0 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants