Allow modification of tablet unhealthy_threshold via debugEnv #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debugEnv. Signed-off-by: Jacques Grove <[email protected]>
Signed-off-by: Jacques Grove <[email protected]>
Signed-off-by: Jacques Grove <[email protected]>
aquarapid
changed the title
Signed-off-by: Jacques Grove <[email protected]>
aquarapid
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
Signed-off-by: Jacques Grove <[email protected]>
sougou
approved these changes
Apr 7, 2021
|
@aquarapid does this need to go into 10.0? |
|
@deepthi it's a bit late, but yes, if possible. |
Signed-off-by: Jacques Grove <[email protected]>
Signed-off-by: Jacques Grove <[email protected]>
|
Oops! Forgot that we need an issue. Can you create one? |
8 tasks
systay
added
Component: Query Serving
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WDYT? Obviously not very clean, so open to suggestions. One thing is that modifying the Config flag isn't atomic, but that's probably fine, since we don't read from it after Init?
Fixes: #7939