Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declarative Online DDL #7725

Merged
merged 25 commits into from
Apr 5, 2021
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3173864
initial support for -declarative online DDL option
shlomi-noach Mar 9, 2021
5eb0cba
DROP TABLE behaves like DROP TABLE IF EXISTS when -declarative strate…
shlomi-noach Mar 9, 2021
09d66d4
towards idempotent CREATE/ALTER
shlomi-noach Mar 9, 2021
2ac01a0
go mod tidy
shlomi-noach Mar 9, 2021
cf1b4ef
generalize onlineDDL flag parsing
shlomi-noach Mar 11, 2021
c0f9b4f
reject ALTER migrations in declarative mode
shlomi-noach Mar 11, 2021
5e6e820
fail ALTER. Mutex already held
shlomi-noach Mar 11, 2021
2e52d97
Parse CREATE TABLE body out of full statement
shlomi-noach Mar 14, 2021
2a91c4f
support -declarative for CREATE and DROP operations
shlomi-noach Mar 14, 2021
79c4b96
support -declarative for CREATE and DROP operations
shlomi-noach Mar 14, 2021
11bb835
gomod
shlomi-noach Mar 14, 2021
9263141
Merge branch 'master' into online-ddl-idempotent
shlomi-noach Mar 14, 2021
9b19e4c
defer table drop
shlomi-noach Mar 16, 2021
5fff50b
Merge branch 'master' into online-ddl-idempotent
shlomi-noach Mar 16, 2021
e192931
Merge remote-tracking branch 'origin/online-ddl-sql-interface-alter' …
shlomi-noach Mar 16, 2021
e16033c
evaluating DB flavor for tengo; only modify the CREATE TABLE statemen…
shlomi-noach Mar 18, 2021
e7fd4bb
created endtoend onlineddl_declarative_test
shlomi-noach Mar 18, 2021
a13f90e
github workflow file for endtoend/onlineddl/declarative test
shlomi-noach Mar 18, 2021
851c3fb
Merge branch 'master' into online-ddl-idempotent
shlomi-noach Mar 18, 2021
ef20c1f
merge master, resolve conflict
shlomi-noach Mar 21, 2021
3f70b5c
typo
shlomi-noach Mar 21, 2021
7603d6a
Reject CREATE TABLE IF NOT EXISTS as its behavior is ambiguous in -de…
shlomi-noach Mar 22, 2021
6f2ea36
merge master, resolve conflict
shlomi-noach Apr 1, 2021
faa1a96
go mod tidy
shlomi-noach Apr 1, 2021
1a4d599
comment fixes per review
shlomi-noach Apr 1, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/cluster_endtoend_onlineddl_declarative.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# DO NOT MODIFY: THIS FILE IS GENERATED USING "make generate_ci_workflows"

name: Cluster (onlineddl_declarative)
on: [push, pull_request]
jobs:

build:
name: Run endtoend tests on Cluster (onlineddl_declarative)
runs-on: ubuntu-18.04

steps:
- name: Set up Go
uses: actions/setup-go@v1
with:
go-version: 1.15

- name: Check out code
uses: actions/checkout@v2

- name: Get dependencies
run: |
sudo apt-get update
sudo apt-get install -y mysql-server mysql-client make unzip g++ etcd curl git wget eatmydata
sudo service mysql stop
sudo service etcd stop
sudo ln -s /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
sudo apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld
go mod download
wget https://repo.percona.com/apt/percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get install -y gnupg2
sudo dpkg -i percona-release_latest.$(lsb_release -sc)_all.deb
sudo apt-get update
sudo apt-get install percona-xtrabackup-24
- name: Run cluster endtoend test
timeout-minutes: 30
run: |
source build.env
eatmydata -- go run test.go -docker=false -print-log -follow -shard onlineddl_declarative
2 changes: 1 addition & 1 deletion .github/workflows/cluster_endtoend_onlineddl_revert.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:

build:
name: Run endtoend tests on Cluster (onlineddl_revert)
runs-on: ubuntu-latest
runs-on: ubuntu-18.04

steps:
- name: Set up Go
Expand Down
14 changes: 9 additions & 5 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ require (
github.com/dave/jennifer v1.4.1
github.com/evanphx/json-patch v4.5.0+incompatible
github.com/go-martini/martini v0.0.0-20170121215854-22fa46961aab
github.com/go-sql-driver/mysql v1.5.0
github.com/go-sql-driver/mysql v1.5.1-0.20210202043019-fe2230a8b20c
github.com/gogo/protobuf v1.3.1
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6 // indirect
github.com/golang/mock v1.3.1
github.com/golang/protobuf v1.3.2
github.com/golang/protobuf v1.3.3
github.com/golang/snappy v0.0.1
github.com/google/go-cmp v0.4.0
github.com/google/go-cmp v0.5.2
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
github.com/google/uuid v1.1.1
github.com/googleapis/gnostic v0.2.0 // indirect
Expand All @@ -50,6 +50,7 @@ require (
github.com/howeyc/gopass v0.0.0-20190910152052-7cb4b85ec19c
github.com/icrowley/fake v0.0.0-20180203215853-4178557ae428
github.com/imdario/mergo v0.3.6 // indirect
github.com/jmoiron/sqlx v1.2.0
github.com/klauspost/compress v1.4.1 // indirect
github.com/klauspost/cpuid v1.2.0 // indirect
github.com/klauspost/pgzip v1.2.4
Expand Down Expand Up @@ -81,6 +82,7 @@ require (
github.com/samuel/go-zookeeper v0.0.0-20200724154423-2164a8ac840e
github.com/satori/go.uuid v1.2.0 // indirect
github.com/sjmudd/stopwatch v0.0.0-20170613150411-f380bf8a9be1
github.com/skeema/tengo v0.0.0-00010101000000-000000000000
github.com/soheilhy/cmux v0.1.4
github.com/spf13/cobra v1.1.1
github.com/spf13/pflag v1.0.5
Expand All @@ -97,12 +99,12 @@ require (
golang.org/x/lint v0.0.0-20190930215403-16217165b5de
golang.org/x/net v0.0.0-20201021035429-f5854403a974
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9
golang.org/x/sync v0.0.0-20201207232520-09787c993a3a
golang.org/x/text v0.3.3
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4
golang.org/x/tools v0.0.0-20201202200335-bef1c476418a
google.golang.org/api v0.13.0
google.golang.org/grpc v1.24.0
google.golang.org/grpc v1.29.1
gopkg.in/DataDog/dd-trace-go.v1 v1.17.0
gopkg.in/asn1-ber.v1 v1.0.0-20181015200546-f715ec2f112d // indirect
gopkg.in/gcfg.v1 v1.2.3
Expand All @@ -117,3 +119,5 @@ require (
k8s.io/code-generator v0.17.3
sigs.k8s.io/yaml v1.1.0
)

replace github.com/skeema/tengo => github.com/planetscale/tengo v0.9.6-ps.v1
101 changes: 97 additions & 4 deletions go.sum

Large diffs are not rendered by default.

Loading