Add common tags for stats backends that support it #7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crowu <[email protected]>
Signed-off-by: crowu <[email protected]>
Signed-off-by: crowu <[email protected]>
Signed-off-by: crowu <[email protected]>
|
@deepthi sorry for the ping - would you mind taking a look when you get a chance? Thanks! :-) |
Signed-off-by: crowu <[email protected]>
Signed-off-by: crowu <[email protected]>
Signed-off-by: crowu <[email protected]>
|
Gentle reminder :-) |
deepthi
reviewed
Apr 12, 2021
I extract it out so that it is possible to reuse stats in other Vitess components that does not set up |
deepthi
approved these changes
Apr 13, 2021
dweitzman
reviewed
Apr 13, 2021
| @@ -46,6 +46,9 @@ var statsBackend = flag.String("stats_backend", "", "The name of the registered | |||
| var combineDimensions = flag.String("stats_combine_dimensions", "", `List of dimensions to be combined into a single "all" value in exported stats vars`) | |||
| var dropVariables = flag.String("stats_drop_variables", "", `Variables to be dropped from the list of exported variables.`) | |||
|
|
|||
| // CommonTags is a comma-separated list of common tags for stats backends | |||
| var CommonTags = flag.String("stats_common_tags", "", `Comma-separated list of common tags for the stats backend. It provides both label and values. Example: label1:value1,label2:value2`) | |||
There was a problem hiding this comment.
Seems like this should use flagutil.StringMapValue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opentsdb and statsd both support common tags that can be attached to all the metrics we emitted. They are useful to identify the latency at keyspace or shard level. However there is no easy way to integrate with that.
This PR does 2 things:
InitWithoutServenvso that we can init them without servenv. This can be useful to reuse the stats backend on other binaries that does not use servenv (e.g., vtorc, vtbench)Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: