Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: internal support for eta_seconds #7630

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Mar 7, 2021

Description

Objective: make both migration progress and ETA accessible to the user.

Initial commits:
This PR adds the column eta_seconds to _vt.schema_migrations and provides the following initial support:

  • Initializes with negative value (negative means "N/A", unknown)
  • accepts a eta=? query param on /schema-migration/report-status (which is called on gh-ost and pt-osc migrations)
  • reports GH_OST_ETA_SECONDS in gh-ost status hook

TODO/related:

  • Make progress pct and ETA available to the user; probably moving away from VExec
  • Provide a SQL interface

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@shlomi-noach
Copy link
Contributor Author

This is now ready for review. This PR only implements internal support for eta_seconds and right now only gh-ost populates that value.

Future PRs will:

  • make this value accessible via SQL interface
  • implement progress/ETA in vreplication based migrations

@shlomi-noach shlomi-noach marked this pull request as ready for review March 8, 2021 07:02
@shlomi-noach shlomi-noach requested review from deepthi and a team March 8, 2021 07:03
@shlomi-noach
Copy link
Contributor Author

cc @piki

Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shlomi-noach shlomi-noach merged commit d9e1392 into vitessio:master Mar 8, 2021
@shlomi-noach shlomi-noach deleted the online-ddl-eta branch March 8, 2021 10:07
@askdba askdba added this to the v10.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants