Online DDL: code cleanup #7589
Merged
Online DDL: code cleanup #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've imported a bunch of files from gh-ost, and now we remove the irrelevant pieces of code Signed-off-by: Shlomi Noach <[email protected]>
systay
approved these changes
Mar 3, 2021
|
Oh... I missed the WIP comment. Got so excited by a cleanup PR |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
|
Now ready for review, did just a bit more cleanup. There's more to come in a future PR. |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…ess into online-ddl-vrepl-cleanup Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
We've imported a bunch of files from gh-ost, and now we remove the irrelevant pieces of code. This PR is all about deleting unused code, or converting code to use Vitess' parser
Related Issue(s)
Checklist
Impacted Areas in Vitess
Components that this PR will affect: