Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Three small bugfixes in Tablets table around stable sort order, display type lookup, and filtering by type #7568

Merged
merged 1 commit into from
Feb 28, 2021
Merged

[vtadmin-web] Three small bugfixes in Tablets table around stable sort order, display type lookup, and filtering by type #7568

merged 1 commit into from
Feb 28, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Feb 28, 2021

Description

Staged: http://vtadmin.puppy.software/tablets

Three small bugfixes on the tablets page:

  • Fixes a bug where filtering by type: didn't work, as the row property used displayType rather than type
  • Fixes a bug where some tablet types were displayed incorrectly due to duplicate values in the TabletType enum
  • Fixes a bug where tablet sort order was unstable for tablets of the same type; an additional sort on alias is added.
  • Adds tests for the above. :)

Ultimately, I think it'd be good to have the API return a readable tablet type string (in addition to, or perhaps instead of the numeric tablet.type value). This way, any other callers to /api/tablets will see PRIMARY instead of MASTER, RDONLY instead of BATCH, etc.

Related Issue(s)

  • N/A

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@doeg
Three small bugfixes in Tablets table around stable sort order, displ…
0e2fb5d 
…ay type lookup, and filtering by type... plus tests

Signed-off-by: Sara Bee <[email protected]>
rohit-nayak-ps
rohit-nayak-ps approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohit-nayak-ps rohit-nayak-ps merged commit e27c7b1 into vitessio:master Feb 28, 2021
@doeg doeg deleted the sarabee-vtadmin-tablet-fixes branch March 1, 2021 00:51
@askdba askdba added the Component: VTAdmin VTadmin interface label Mar 4, 2021
@askdba askdba added this to the v10.0 milestone Mar 4, 2021
@doeg doeg changed the title Three small bugfixes in Tablets table around stable sort order, display type lookup, and filtering by type [vtadmin-web] Three small bugfixes in Tablets table around stable sort order, display type lookup, and filtering by type Mar 16, 2021
@ajm188 ajm188 mentioned this pull request Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@doeg @rohit-nayak-ps @askdba