-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtadmin-api] Reorganize tablet-related functions into vtadmin/cluster/cluster.go #7553
Merged
rohit-nayak-ps
merged 8 commits into
vitessio:master
from
tinyspeck:sarabee-vtadmin-api-tidying
Feb 26, 2021
Merged
[vtadmin-api] Reorganize tablet-related functions into vtadmin/cluster/cluster.go #7553
rohit-nayak-ps
merged 8 commits into
vitessio:master
from
tinyspeck:sarabee-vtadmin-api-tidying
Feb 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
Signed-off-by: Sara Bee <[email protected]>
ajm188
reviewed
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this separation a lot better; thank you for doing it!! I have a couple small comments but looks great
Signed-off-by: Sara Bee <[email protected]>
@ajm188 this is ready for another pass, when you get a sec. |
ajm188
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here's the refactoring I promised to do for #7528 (comment).
Changes:
tablets.go
intocluster.go
so functions have a signature offunc (c *Cluster) ...
getTablets
,findTablet
, andfindNTablets
out ofapi.go
and intocluster.go
+ adds testserrors.go
out ofpackage vtadmin
and intopackage errors
so that it can be shared byapi.go
+cluster.go
I staged this internally + it works as expected.
Related Issue(s)
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: