Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-web] An initial pass for tablet filters #7515

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented Feb 18, 2021

Signed-off-by: Sara Bee [email protected]

Description

✨ Staging: http://vtadmin.puppy.software/

tablet-filtering.mov

This is still VERY rough around the edges, but I'm happy with it so far! I feel like this implementation atones for a lot of the sins I committed in our internal prototype. :') It's also super performant, despite not yet spending any time on performance specifically!

That said! The behaviour of this also differs significantly from our internal prototype. In a good way, I hope, but you never know! To that end, I'm leaving a lot of the polish for later so we can focus on the functional bits first.

By "polish", I mean things like:

  • Persisting search state in the URL
  • Dropdown filters
  • Typeahead suggestions
  • Button-like rendering for key/value tokens
  • Smoother interactions between the input and the table. Right now, for example, rows can disappear when you're typing.
  • Probably a better parser, as mentioned in the comments!
  • etc. etc.

Related Issue(s)

N/A

Checklist

  • Should this PR be backported? N/A
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really really cool! lg2m

@deepthi deepthi merged commit fd70476 into vitessio:master Feb 23, 2021
@askdba askdba added the Component: VTAdmin VTadmin interface label Feb 26, 2021
@askdba askdba added this to the v10.0 milestone Feb 26, 2021
@doeg doeg deleted the sarabee-vtadmin-tablet-filtering branch March 1, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants