Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds another case to merge routes for information_schema queries #7504

Merged

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Feb 17, 2021

Fixes #7376

go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
@harshit-gangal
Copy link
Member

ast does not have to do with what the table qualifier is, we can move the ContainsOnlySystemSchema() logic from ast to logical plan and they can provide the same information needed for planner.

cc: @systay

Signed-off-by: Akilan Selvacoumar <[email protected]>

Signed-off-by:  <[email protected]>
@Akilan1999 Akilan1999 force-pushed the merge-information-schema branch from 9aa4d32 to 4cd2a7a Compare February 18, 2021 07:32
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One nit comment

go/vt/sqlparser/ast_funcs.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/route.go Outdated Show resolved Hide resolved
go/vt/sqlparser/cached_size.go Show resolved Hide resolved
@harshit-gangal harshit-gangal merged commit 02376a3 into vitessio:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants