-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds another case to merge routes for information_schema queries #7504
Merged
harshit-gangal
merged 4 commits into
vitessio:master
from
GuptaManan100:merge-information-schema
Feb 21, 2021
Merged
Adds another case to merge routes for information_schema queries #7504
harshit-gangal
merged 4 commits into
vitessio:master
from
GuptaManan100:merge-information-schema
Feb 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuptaManan100 <[email protected]>
GuptaManan100
requested review from
harshit-gangal and
systay
as code owners
February 17, 2021 08:32
…e-information-schema Signed-off-by: <[email protected]>
ast does not have to do with what the table qualifier is, we can move the ContainsOnlySystemSchema() logic from ast to logical plan and they can provide the same information needed for planner. cc: @systay |
Signed-off-by: Akilan Selvacoumar <[email protected]> Signed-off-by: <[email protected]>
Akilan1999
force-pushed
the
merge-information-schema
branch
from
February 18, 2021 07:32
9aa4d32
to
4cd2a7a
Compare
harshit-gangal
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One nit comment
GuptaManan100
commented
Feb 18, 2021
Signed-off-by: GuptaManan100 <[email protected]>
Akilan1999
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7376