[vtadmin-web] Add DataTable component with URL pagination #7487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee [email protected]
Description
✨ Staged at http://vtadmin.puppy.software, with a modified
DEFAULT_PAGE_SIZE
of 5 to show the pagination. :)Changes in this PR:
useURLQuery
anduseURLPagination
. Plus, lots of tests.I've yet to spend much (any) time worrying about memoization or performance -- I'll do a performance pass when we have filtering, loading state, etc. in place.
I also pinky-promise that I will write some sort of (heavy scare quotes) "best practices" doc around testing. It's wonderfully easy... but not necessarily straightforward. 😈
pagination.mov
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A
Impacted Areas in Vitess
Components that this PR will affect: