docker vitess/vtctlclient: Install curl #7466
Conversation
Install curl into the docker image vitess/vtctlclient. That way,
for clients using this container, not only can they interact
with vtctld via vtctlclient, but they can also interact with
vtctld and other Vitess components via their HTTP APIs, and can
also interact with the Kubernetes API server over HTTP.
When tested with Docker Desktop for Mac, Docker version 20.10.2,
using the command
docker build --compress -f Dockerfile -t "vitess/vtctlclient:latest" .
the original Dockerfile generates an artifact that is 94.4MB
(according to docker image ls), whereas the new Dockerfile
generates a 102MB image, about an 8% increase in the image's
size.
Signed-off-by: Jordan Moldow <[email protected]>
|
I am personally ok with this, but I would want to get @deepthi's opinion before we merge |
We incline towards adding useful tools to the images. For a large image like |
|
Just adding a note here: before this merged, https://hub.docker.com/r/vitess/vtctlclient/tags?page=1&ordering=last_updated&name=latest showed Compressed Size as 36.24 MB. I'll write what the size is after the new latest image is built and pushed. |
Install curl into the docker image vitess/vtctlclient. That way,
for clients using this container, not only can they interact
with vtctld via vtctlclient, but they can also interact with
vtctld and other Vitess components via their HTTP APIs, and can
also interact with the Kubernetes API server over HTTP.
When tested with Docker Desktop for Mac, Docker version 20.10.2,
using the command
docker build --compress -f Dockerfile -t "vitess/vtctlclient:latest" .
the original Dockerfile generates an artifact that is 94.4MB
(according to docker image ls), whereas the new Dockerfile
generates a 102MB image, about an 8% increase in the image's
size.
Backport of pull request vitessio#7466.
Signed-off-by: Jordan Moldow <[email protected]>
|
After this merged, https://hub.docker.com/r/vitess/vtctlclient/tags?page=1&ordering=last_updated&name=latest showed Compressed Size as 37.85 MB. A 4.4% / 1.61 MB increase in Compressed Size. |
Description
Install curl into the docker image vitess/vtctlclient. That way,
for clients using this container, not only can they interact
with vtctld via vtctlclient, but they can also interact with
vtctld and other Vitess components via their HTTP APIs, and can
also interact with the Kubernetes API server over HTTP.
Signed-off-by: Jordan Moldow [email protected]
Checklist
Deployment Notes
When tested with Docker Desktop for Mac, Docker version 20.10.2,
using the command
the original Dockerfile generates an artifact that is 94.4MB
(according to docker image ls), whereas the new Dockerfile
generates a 102MB image, about an 8% increase in the image's
size.
I would understand if the team would rather not include this dependency in this slim image.
Impacted Areas in Vitess
Components that this PR will affect:
vitess/vtctlclient