Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe table to route based on table name and qualifier #7445

Merged
merged 8 commits into from
Feb 7, 2021
Merged

Describe table to route based on table name and qualifier #7445

merged 8 commits into from
Feb 7, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Feb 4, 2021 •
edited
Loading

Description

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@harshit-gangal
fix wrangler test
15495af 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal marked this pull request as ready for review February 4, 2021 19:05
shlomi-noach
shlomi-noach approved these changes Feb 7, 2021
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick

go/vt/sqlparser/ast.go Show resolved Hide resolved
@harshit-gangal
addressed review comments
f8dcedf 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal merged commit 3c5e2c2 into vitessio:master Feb 7, 2021
@harshit-gangal harshit-gangal deleted the desc-fix branch February 7, 2021 18:00
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

@sougou sougou Awaiting requested review from sougou

@systay systay Awaiting requested review from systay

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Unqualified DESC fails
3 participants
@harshit-gangal @shlomi-noach @askdba