Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix information_schema query with system schema in table_schema filter #7430

Merged
merged 6 commits into from
Feb 3, 2021
Merged

Fix information_schema query with system schema in table_schema filter #7430

merged 6 commits into from
Feb 3, 2021

Conversation

harshit-gangal
Copy link
Member

Description

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@harshit-gangal
added system schema in where clause plan test
7f5fa4d 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
added executor unit test
f42a78c 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
added logic to check table_schema of where clause and redirect to def…
1069aa8 
…ault route if it is a system schema

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
added e2e test
6fd0695 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
set the bindvars for the normalized predicates and remove schema name…
8707f02 
… from bv if tablet will replace it

Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal harshit-gangal marked this pull request as ready for review February 2, 2021 11:07
@harshit-gangal harshit-gangal added this to the v10.0 milestone Feb 2, 2021
systay
systay approved these changes Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm just missing an end to end test that tests the query we set out to fix in the first place:

mysql> SELECT COUNT(*) FROM INFORMATION_SCHEMA.TABLES WHERE table_schema = 'performance_schema' AND table_name = 'foo';

@harshit-gangal
Copy link
Member Author

Looks good. I'm just missing an end to end test that tests the query we set out to fix in the first place:

mysql> SELECT COUNT(*) FROM INFORMATION_SCHEMA.TABLES WHERE table_schema = 'performance_schema' AND table_name = 'foo';

addressed.

@harshit-gangal harshit-gangal merged commit 68cda5e into vitessio:master Feb 3, 2021
@harshit-gangal harshit-gangal deleted the systemschema-fix branch February 3, 2021 07:09
@harshit-gangal harshit-gangal mentioned this pull request May 9, 2021
Closed
@rafael rafael mentioned this pull request May 10, 2021
Merged
systay pushed a commit to planetscale/vitess that referenced this pull request May 11, 2021
@harshit-gangal @systay
Fix information_schema query with system schema in table_schema filter
5174796 
Backport of vitessio#7430
This is a combination of 6 commits.

* added system schema in where clause plan test
* added executor unit test
* added logic to check table_schema of where clause and redirect to default route if it is a system schema
* added e2e test
* set the bindvars for the normalized predicates and remove schema name from bv if tablet will replace it
* added e2e test having table_schema and table_name in where clause

Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
@systay systay mentioned this pull request May 11, 2021
Merged
rafael pushed a commit to tinyspeck/vitess that referenced this pull request May 11, 2021
@harshit-gangal @rafael
Fix information_schema query with system schema in table_schema filter
11e6791 
Backport of vitessio#7430
This is a combination of 6 commits.

* added system schema in where clause plan test
* added executor unit test
* added logic to check table_schema of where clause and redirect to default route if it is a system schema
* added e2e test
* set the bindvars for the normalized predicates and remove schema name from bv if tablet will replace it
* added e2e test having table_schema and table_name in where clause

Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>

Signed-off-by: Rafael Chacon <[email protected]>
@ajm188 ajm188 mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

Assignees
No one assigned
Labels
Component: Query Serving
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Querying information_schema does not work for combination of table_schema and table_name filter.
2 participants
@harshit-gangal @systay