Add ErrorGroup to package concurrency, use in waitOnNMinusOneTablets
#7429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <[email protected]>
|
I'm late to the merge party but just wanna say this change is :chef-kiss: 🌟 |
|
Looks great! |
setassociative
pushed a commit
to tinyspeck/vitess
that referenced
this pull request
Mar 8, 2021
Add `ErrorGroup` to package concurrency, use in `waitOnNMinusOneTablets`
ajm188
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a larger effort to migrate
PlannedReparentShardandEmergencyReparentShardfor #7428, and I'm trying to lead with some refactors to make the actual final change less scary (I'm working on a few more extractions that will have tests attached to them, which should hopefully give us even more confidence in the final change).Related Issue(s)
Checklist
Deployment Notes
Impacted Areas in Vitess
Components that this PR will affect: