Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protoutil package, refactor ISP to use it #7421

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Jan 31, 2021

Description

We're going to be dealing with a lot of duration pb types.

Signed-off-by: Andrew Mason [email protected]

Related Issue(s)

Checklist

  • Should this PR be backported? No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

We're going to be dealing with a lot of duration pb types.

Signed-off-by: Andrew Mason <[email protected]>
@ajm188 ajm188 requested review from doeg and rohit-nayak-ps January 31, 2021 21:06
@ajm188 ajm188 requested a review from sougou as a code owner January 31, 2021 21:06
@rohit-nayak-ps rohit-nayak-ps merged commit 483b85c into vitessio:master Feb 1, 2021
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@ajm188 ajm188 deleted the am_protoutil_package branch March 4, 2021 21:32
@ajm188 ajm188 added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants