Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use provided xtrabackup_root_path to find xbstream #7359

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jan 23, 2021

Description

Use vttablet option xtrabackup_root_path to find the xbstream binary.
If the option is not specified, we will continue to expect it to be present in PATH.
This behavior is consistent with how we treat the xtrabackup binary.

Related Issue(s)

Fixes #7356

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build
  • VTAdmin

@deepthi deepthi requested a review from aquarapid January 23, 2021 21:42
Copy link
Contributor

@aquarapid aquarapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 0ca4f99 into vitessio:master Jan 25, 2021
@deepthi deepthi deleted the ds-xb-path branch January 25, 2021 04:18
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xbstream should use xtrabackup_root_path
3 participants