-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change @@version and @@version_comment #7337
Conversation
Signed-off-by: Andres Taylor <[email protected]>
Should we not have a variable as vitess_version versus default mysql_version?
Otherwise, this could be confusing for generic MySQL users expecting a different result. |
@askdba: I don't think it's a good idea to simply pass on the underlying mysql version like we are doing today - they are not interacting with mysql of that version, they are interaction with Vitess which is very different. It already creates problems when users are running mysql 8.0, since some libraries/apps/orms start using features that Vitess does not support. |
@systay the docs need to be updated. |
Something for the eventual 10.0 release notes: the server version we advertise to connectors in on the protocol level has changed from "5.7.9-Vitess" to "5.7.9-vitess-10.0.0-SNAPSHOT" (or whatever); if anyone introspects this value, they might care. |
Description
This PR changes the
@@version
and@@version_comment
values to include information about the Vitess version.It also removed the recently added
@@vitess_version
.The change includes a new file,
version.go
that contains very little. It's kept minimal like this to be easy for our release scripts to update the named version.